Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): use precise capturing on 1.82+ #435

Merged
merged 8 commits into from
Nov 16, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 36 additions & 32 deletions .github/workflows/rustlib.yml
jeertmans marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
on:
pull_request:
paths:
- '**.rs'
- '**/Cargo.toml'
- "**.rs"
- "**/Cargo.toml"
workflow_dispatch:

name: Library testing
Expand All @@ -12,47 +12,51 @@ jobs:
name: Rustdoc
runs-on: ubuntu-latest
steps:
- name: Checkout sources
uses: actions/checkout@v4
- name: Checkout sources
uses: actions/checkout@v4

- name: Install nightly toolchain
uses: dtolnay/rust-toolchain@nightly
- name: Install nightly toolchain
uses: dtolnay/rust-toolchain@nightly

- name: Cache dependencies
uses: Swatinem/rust-cache@v2
- name: Cache dependencies
uses: Swatinem/rust-cache@v2

- name: Check rustdoc build
run: RUSTDOCFLAGS='--cfg docsrs' cargo +nightly doc --features debug -Zunstable-options -Zrustdoc-scrape-examples
- name: Check rustdoc build
run: RUSTDOCFLAGS='--cfg docsrs' cargo +nightly doc --features debug -Zunstable-options -Zrustdoc-scrape-examples

tests:
name: Tests
strategy:
matrix:
rust:
- stable
- beta
- nightly
- 1.70.0 # current MSRV
- 1.82.0 # precise capturing
- stable
- beta
- nightly
os:
- macos-latest
- ubuntu-latest
- windows-latest
- macos-latest
- ubuntu-latest
- windows-latest
features:
- "" # default features
- "--features forbid_unsafe"
- "" # default features
- "--features forbid_unsafe"

runs-on: ${{ matrix.os }}
steps:
- name: Checkout sources
uses: actions/checkout@v4

- name: Install stable toolchain
uses: dtolnay/rust-toolchain@stable

- name: Cache dependencies
uses: Swatinem/rust-cache@v2

- name: Check that tests run
uses: actions-rs/cargo@v1
with:
command: test
args: --workspace --verbose ${{ matrix.features }}
- name: Checkout sources
uses: actions/checkout@v4

- name: Install stable toolchain
uses: dtolnay/rust-toolchain@stable
with:
toolchain: ${{ matrix.rust }}

- name: Cache dependencies
uses: Swatinem/rust-cache@v2

- name: Check that tests run
uses: actions-rs/cargo@v1
with:
command: test
args: --workspace --verbose ${{ matrix.features }}
3 changes: 3 additions & 0 deletions logos-codegen/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ syn = { version = "2.0.13", features = ["full"] }
pretty_assertions = "1.4.0"
rstest = "0.18.2"

[build-dependencies]
rustc_version = "0.4.1"

[features]
# Enables debug messages
debug = []
Expand Down
17 changes: 17 additions & 0 deletions logos-codegen/build.rs
jeertmans marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
use rustc_version::{version_meta, Version};

fn main() {
let version_meta = version_meta().expect("Could not get Rust version");

let rustc_version = version_meta.semver;
let trimmed_rustc_version = Version::new(
rustc_version.major,
rustc_version.minor,
rustc_version.patch,
);

println!("cargo:rustc-check-cfg=cfg(rust_1_82)");
if trimmed_rustc_version >= Version::new(1, 82, 0) {
println!("cargo:rustc-cfg=rust_1_82");
}
}
8 changes: 7 additions & 1 deletion logos-codegen/src/generator/leaf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,17 @@ impl<'a> Generator<'a> {
let arg = &inline.arg;
let body = &inline.body;

#[cfg(not(rust_1_82))]
let ret = quote!(impl CallbackResult<'s, #ty, #this>);

#[cfg(rust_1_82)]
let ret = quote!(impl CallbackResult<'s, #ty, #this> + use<'a>);

quote! {
#bump

#[inline]
fn callback<'s>(#arg: &mut Lexer<'s>) -> impl CallbackResult<'s, #ty, #this> {
fn callback<'s>(#arg: &mut Lexer<'s>) -> #ret {
#body
}

Expand Down
Loading