Elham/go1 #31
Open
Elham/go1 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximilienNaveau
approved these changes
May 26, 2023
| @@ -12,6 +12,7 @@ | |||
| from mim_control.robot_impedance_controller import RobotImpedanceController | |||
| from bullet_utils.env import BulletEnvWithGround | |||
| from robot_properties_solo.solo12wrapper import Solo12Robot, Solo12Config | |||
| from robot_properties_go1.go1wrapper import Go1Robot, Go1Config | |||
There was a problem hiding this comment.
would it be possible to add a try catch here for the optional dependencies?
for example one wants to run on solo but not on go1 and still need to install go1 to run the demo...
It would be nice to allow the users to run it without solo if you run go1 and the other way around.
WDYT?
| @@ -14,6 +14,7 @@ This packages contains generic controllers that can be used for a biped, quadrup | |||
| - BulletUtils (Optional, needed to run demos) | |||
| - Robot_Properties_Solo (Optional, needed to run demos) | |||
| - Robot_Properties_Bolt (Optional, needed to run demos) | |||
| - Robot_Properties_Go1 (Optional, needed to run demos) | |||
There was a problem hiding this comment.
we miss something in the CMakeLists.txt to check if those optional dependencies are installed or not...
It is not needed per say but would be nice IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I add go1 to a demo of this package.
How I Tested
I ran it on my computer.