Added datatype detection configuration and titles to all icons and new remove icon #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
May 3, 2019 11:11
Added jsx to webpack resolve Added a title to every icon type Added a new Bin icon to differeniate between remove and cancel
Added props to allow configuration of what datatypes are detected
|
thanks for contributing! I can review this week. sorry for the delay on feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this repo is abandoned so this won't get completed, but the small changes I've done may be useful to others so i'll create the PR anyway.
There's quite a lot of changes that eslint auto fixed thrown in, but these are my actual codes changes
Added a way to configure what data types can be detected. My use case for this is that I never want a user to be given the option to replace a date with the format that is suggest.
Added titles to all editor icons and replaced the remove icon with a new Bin icon. I think this was necessary as one of the icons already had a title,but none of the others did. And the cancel icon been the same as the remove icon was confusing to users.