Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Done #1

wants to merge 4 commits into from

Conversation

LongAtGitHub
Copy link

No description provided.

@pcantrell
Copy link
Contributor

pcantrell commented Oct 4, 2024

Good work!

For the final step of this assignment:

  1. Open up the “Files changed” tab of this pull request.
  2. Open up my own solution to the homework so that you can compare the two:

Walk through the two solutions, comparing one small chunk of code at a time. Things to think about as you go:

  • Remember: different doesn’t necessarily mean wrong. Sometimes one way is clearly better than another, and sometimes you can just say, “Yup, that works too!”
  • In the java-type-checker, did you ever rely on using strings to compare types? Would your solution work if there are two different types that happen to have the same names?
  • Are there differences between our approaches that would result in different language behavior — different type checking or different member lookup — but the directions and tests simply didn’t specify the desired behavior enough to make one clearly the correct one? (Think about the poor language implementers who have to deal with this sort of question all the time!)
  • Are there Python or Java language features you notice that you’d like to investigate further?
  • Are there Python or Java language features that I should learn from you and investigate further? (This often happens with student work!)
  • Did you forget to delete any commented-out or otherwise unused code, or extraneous debug statements?

Now, to complete the assignment:

Write a brief note about one or two things that stood out to you as you compare the two solutions.

You can ask a question, or just name something notable. Post these comments here in this comment thread and/or as comments on individual lines of your code in the “Files changed” tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants