This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Adding support for setting proxy on Client #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TreatWarningsAsErrors to all projects
-- added comments for method
sharwell
reviewed
Jan 24, 2017
| @@ -23,6 +23,7 @@ | |||
| <DefineConstants>DEBUG;TRACE</DefineConstants> | |||
| <ErrorReport>prompt</ErrorReport> | |||
| <WarningLevel>4</WarningLevel> | |||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | |||
There was a problem hiding this comment.
💡 A better way to do this is using a rule set file to actually set the severity of the original issue to Error instead of Warning.
There was a problem hiding this comment.
Sorry, most of these changes are not my own but things that existed in master but not v0.1.1.0
If some of these changes don't make sense, could someone create a branch on the tag v0.1.1.0 so that I can make a pull request with only my changes?
Or should I revert some of the commits in this pull request?
There was a problem hiding this comment.
@jcl8746 No problem, just putting the info out there for the future 😄
sharwell
pushed a commit
to sharwell/Git.hub
that referenced
this pull request
Apr 6, 2018
Adopt Microsoft.VisualStudio.Threading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.