Add validation for scoped slice bytes

m4b · Oct 28, 2024 · 96ae98f · 96ae98f
1 parent b4c2672
commit 96ae98f
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/src/pe/debug.rs b/src/pe/debug.rs
@@ -167,6 +167,13 @@ impl<'a> DebugData<'a> {
                     ))
                 })?;
 
+        // Ensure that the offset and size do not exceed the length of the bytes slice
+        if offset + dd.size as usize > bytes.len() {
+            return Err(error::Error::Malformed(format!(
+                "ImageDebugDirectory offset {:#x} and size {:#x} exceeds the bounds of the bytes size {:#x}",
+                offset, dd.size, bytes.len()
+            )));
+        }
         let data = &bytes[offset..offset + dd.size as usize];
         let iterator = ImageDebugDirectoryIterator { data, rva_offset };