Simplify POGOEntryIterator::next

m4b · Oct 28, 2024 · 3651bd7 · 3651bd7
1 parent ddca65d
commit 3651bd7
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/pe/debug.rs b/src/pe/debug.rs
@@ -818,7 +818,6 @@ impl<'a> Iterator for POGOEntryIterator<'a> {
             Err(error) => return Some(Err(error.into())),
         };
 
-        let name_offset_start = offset;
         if offset >= self.data.len() {
             return Some(Err(error::Error::Malformed(format!(
                 "Offset {:#x} is too big for containing name field of POGO entry (rva {:#x} and size {:#X})",
@@ -833,8 +832,8 @@ impl<'a> Iterator for POGOEntryIterator<'a> {
                         rva, size
                     ))));
                 }
-                let name = &self.data[name_offset_start..name_offset_start + pos + 1];
-                offset = name_offset_start + pos + 1;
+                let name = &self.data[offset..offset + pos + 1];
+                offset = offset + pos + 1;
                 // Align to the next u32 boundary
                 offset = (offset + 3) & !3; // Round up to the nearest multiple of 4
                 name