Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issue 44 and 63 #64

Closed
wants to merge 1 commit into from
Closed

Address issue 44 and 63 #64

wants to merge 1 commit into from

Conversation

tztsai
Copy link

@tztsai tztsai commented Jul 18, 2023

To address issue #44, I added a random_state argument to the sample function in src/gz21_ocean_momentum/analysis/utils.py, and a seed_all function in src/gz21_ocean_momentum/utils.py.
To address issue #63, I moved net._final_transformation = lambda x: x from the test file tests/models/test_fully_conv_net.py into the __init__ method of FullyCNN.

@raehik
Copy link
Contributor

raehik commented Jul 19, 2023

Thanks for this! Right way forwards on the seeding issue. seed_all doesn't currently get used -- in @CemGultekin1 's fork, torch.random_seed is called early on in trainScript.py:

https://github.com/CemGultekin1/gz21/blob/c4c98c30778e7006a69226d814d36537737a5216/gz21/trainScript.py#L133

We probably want to place a call to seed_all around there. Otherwise, I'm happy with the shotgun approach of trying to seed as much as possible in case it crops up in any deeper calls.

I commented on #63 regarding the model final transformation issue. If you'd make a new branch just for the random seed changes, I'd gladly merge it in by itself (up to you).

@tztsai
Copy link
Author

tztsai commented Jul 19, 2023

Thanks! I'll make a new branch for the random seeding.

@raehik
Copy link
Contributor

raehik commented Aug 1, 2023

Both changes were split out into smaller PRs -- closing.

@raehik raehik closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants