Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training #34

Closed
wants to merge 7 commits into from
Closed

Training #34

wants to merge 7 commits into from

Conversation

arthurBarthe
Copy link
Collaborator

@arthurBarthe arthurBarthe commented Apr 18, 2023

The aim of this PR is to make sure the training code runs properly, issue #33 which includes:

  • bash script for training
  • set of training parameters defined in separate file
  • basic test function to verify that this is running

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@raehik raehik changed the base branch from main to src_and_poetry April 18, 2023 12:50
@dorchard
Copy link
Collaborator

Could we get some more information on this PR? I believe that what this PR is doing is updating the existing training code to make sure it can compile/run again and be more easily deployed? Are there sub tasks here?

@raehik
Copy link
Contributor

raehik commented May 9, 2023

Note this PR is currently based off the wrong branch! It needs rebasing before merging.

@mondus mondus marked this pull request as draft May 9, 2023 09:55
@mondus
Copy link
Contributor

mondus commented May 9, 2023

This is on hold until #30 is completed.

@raehik
Copy link
Contributor

raehik commented May 16, 2023

The changes here were manually added over in #39 , now merged. Closing.

@raehik raehik closed this May 16, 2023
@MarionBWeinzierl MarionBWeinzierl deleted the training branch September 29, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants