Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dorchard #100 changes rebased on main #102

Merged
merged 3 commits into from
Nov 9, 2023
Merged

dorchard #100 changes rebased on main #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eabf77d
update author
dorchard Nov 8, 2023
d3947e5
fix training script parameter bug on default for learning rate
dorchard Nov 8, 2023
ce70a34
fix in datasets module to match import structure
dorchard Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject-poetry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ namespaces = false # to disable scanning PEP 420 namespaces (true by default)
name = "gz21_ocean_momentum"
version = "0.2.0"
description = "TODO"
authors = ["Sébastien Eustace <[email protected]>"]
authors = ["Arthur Guillaumin <[email protected]>"]
readme = "README.md"
packages = [{include = "poetry_demo"}]

Expand Down
2 changes: 1 addition & 1 deletion src/gz21_ocean_momentum/data/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def add_targets_transform(self, transform):
)
self.transforms["targets"].add_transform(transform)

def fit(self, x: torch.utils.data.Dataset):
def fit(self, x: torch.Dataset):
"""
Call the fit method of all array transforms in the list
of features and target transforms on the passed Dataset.
Expand Down
2 changes: 1 addition & 1 deletion src/gz21_ocean_momentum/trainScript.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ def check_str_is_None(string_in: str):
parser.add_argument("--batchsize", type=int, default=8)
parser.add_argument("--n_epochs", type=int, default=100)
parser.add_argument(
"--learning_rate", type=learning_rates_from_string, default={"0\1e-3"}
"--learning_rate", type=learning_rates_from_string, default="0/1e-3"
)
parser.add_argument("--train_split", type=float, default=0.8, help="Between 0 and 1")
parser.add_argument(
Expand Down
Loading