Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building with pip / pyproject.toml #9

Closed
jatkinson1000 opened this issue Feb 16, 2023 · 4 comments · Fixed by #13
Closed

Add support for building with pip / pyproject.toml #9

jatkinson1000 opened this issue Feb 16, 2023 · 4 comments · Fixed by #13
Assignees
Labels
code review Resulting from Feb 2023 code review documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jatkinson1000
Copy link
Member

Currently poetry? but with conda files kicking around.

Suggest we start by:

  • Pull out conda, poetry, and any other mix of existing installation code
  • a simple pyproject.toml installation that can be build by cloning and pip install -e .

Then add in other desired build systems once code is working.

@jatkinson1000
Copy link
Member Author

Discussed with @raehik
Potential workflow:

  • Branch off of first commit to repo (new_main)
  • Change build system
  • Open pull request
  • Eventually archive main and then write main-new onto main.

@jatkinson1000 jatkinson1000 added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 16, 2023
@raehik
Copy link
Contributor

raehik commented Feb 16, 2023

Working on building with pyproject.toml / pip at #13 .

@jatkinson1000
Copy link
Member Author

As suggested by @christopheredsall once there is something simple that can be pip installed we might want to tag it as 'alpha' or 'pre-release' so that there is something that works and closely reflects the original; paper code before we start merging other development branches.

@jatkinson1000 jatkinson1000 linked a pull request Feb 17, 2023 that will close this issue
@jatkinson1000 jatkinson1000 mentioned this issue Feb 20, 2023
5 tasks
@jatkinson1000
Copy link
Member Author

main has now been moved to src_and_poetry, with main_new being moved to main.
To bring local copies into line please run:

git branch -m main src_and_poetry
git branch -m main-new main
git fetch origin
git branch -u origin/src_and_poetry src_and_poetry
git branch -u origin/main main
git remote set-head origin -a

from within your local clone.

PR #13 for the overall packaging issue is now targeting main.

@jatkinson1000 jatkinson1000 added the code review Resulting from Feb 2023 code review label Mar 1, 2023
@raehik raehik changed the title Sort packaging Add support for building with pip / pyproject.toml Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review Resulting from Feb 2023 code review documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants