Merge pull request #28 from avantcredit/typofix

bugfix, passing down silent_read_csv param
m-deck · Jun 10, 2016 · f0e8c11 · f0e8c11
2 parents 10ab731 + 7af89b1
commit f0e8c11
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -2,7 +2,7 @@ Package: looker3
 Type: Package
 Title: looker3 (http://github.com/abelcastilloavant/avant-looker3)
 Description: Pull data from Looker using the fancy new 3.0 API.
-Version: 0.1.10
+Version: 0.1.11
 Author: Abel Castillo <[email protected]>
 Maintainer: Abel Castillo <[email protected]>
 Authors@R: c(person("Abel", "Castillo",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,6 @@
+# Version 0.1.11
+- Fixed bug where `looker3` was not passing `silent_read_csv` to `run_inline_query`.
+
 # Version 0.1.10
 - Added a param `silent_csv_read`, to switch off/on warnings while reading the stream into a data frame.
 

diff --git a/R/looker3.R b/R/looker3.R
@@ -59,7 +59,7 @@ looker3 <- checkr::ensure(pre = list(   # model, view, and fields are
     }
 
     run_inline_query(looker_setup$LOOKER_URL, looker_setup$LOOKER_ID, looker_setup$LOOKER_SECRET,
-      model, view, fields, filters, limit)
+      model, view, fields, filters, limit, silent_read_csv)
   }
 )
 

diff --git a/tests/testthat/test-looker3.R b/tests/testthat/test-looker3.R
@@ -45,7 +45,7 @@ withr::with_envvar(c(
     with_mock(
       `looker3:::run_inline_query` = function(url, id, secret,
                                              model, view, fields, filters,
-                                             limit) {
+                                             limit, ...) {
         list(url = url, id = id, secret = secret, model = model,
              view = view, fields = fields, filters = filters,
              limit = limit)
-Original file line number
+Diff line change
@@ Expand Up @@
         }
         run_inline_query(looker_setup$LOOKER_URL, looker_setup$LOOKER_ID, looker_setup$LOOKER_SECRET,
-          model, view, fields, filters, limit)
+          model, view, fields, filters, limit, silent_read_csv)
       }
     )
@@ Expand Down @@