Merge pull request #20 from avantcredit/switch_to_readr

switch to readr

DESCRIPTION

@@ -2,7 +2,7 @@ Package: looker3
 Type: Package
 Title: looker3 (http://github.com/abelcastilloavant/avant-looker3)
 Description: Pull data from Looker using the fancy new 3.0 API.
-Version: 0.1.6
+Version: 0.1.7
 Author: Abel Castillo <[email protected]>
 Maintainer: Abel Castillo <[email protected]>
 Authors@R: c(person("Abel", "Castillo",
@@ -15,6 +15,7 @@ Imports:
     httr,
     jsonlite,
     cacher,
+    readr,
     checkr (>= 0.0.4.9007)
 Suggests:
     testthat,

NEWS.md

@@ -1,3 +1,6 @@
+# Version 0.1.6
+- `extract_query_result` now uses `readr::read_csv` instead of `utils::read.csv` under the hood.
+
 # Version 0.1.6
 - removed `logout_api_call`, using `cacher` to cache tokens instead.
 

R/response_handlers.R

@@ -41,6 +41,6 @@ handle_logout_response <- function(logout_response) {
 extract_query_result <- function(query_response) {
   validate_response(query_response)
   data_from_query <- httr::content(query_response)
-  utils::read.csv(text = data_from_query)
+  readr::read_csv(data_from_query)
 }
 

circle_installations.R

@@ -1,6 +1,7 @@
-devtools::install_github("hadley/devtools");
-devtools::install_github("hadley/[email protected]");
-devtools::install_github("klutometis/[email protected]");
-devtools::install_github("peterhurford/[email protected]");
+devtools::install_github("hadley/devtools")
+devtools::install_github("hadley/[email protected]")
+devtools::install_github("klutometis/[email protected]")
+devtools::install_github("peterhurford/[email protected]")
+devtools::install_github("hadley/readr")
 devtools::install_github("jimhester/covr")
 

tests/testthat/test-response_handlers.R

@@ -38,8 +38,11 @@ describe("processing successful responses", {
       expect_true(handle_logout_response(fake_logout_response))
     })
     test_that("extract_query_result returns a data frame", {
-      expect_equal(extract_query_result(fake_query_response),
-        data.frame(ID = 1, VALUE = 2))
+      result <- extract_query_result(fake_query_response)
+      # readr::read_csv adds extra classes,
+      # so let's remove them before making our comparison
+      class(result) <- "data.frame"
+      expect_equal(result, data.frame(ID = 1, VALUE = 2))
     })
   })  
 })