-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix_dot function #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EricaCMitchell sorry, no go.
- MADNESS lacks standard format convention. So the code is pretty much formatted randomly. (some ppl even use tabs, which is makes the code look different in different editors ... maybe wrong default still better than no default???)
- Never good idea to reformat existing code. Makes code review or history tracking impossible.
Please extract the new changes out and resubmit.
I reverted the formatting. Although there's no standard format, I am getting a lot of clang-tidy suggestions, such as: performance-unnecessary-value-param, readability-avoid-const-params-in-decls, google-explicit-constructor, and cppcoreguidelines-pro-type-member-init. Is it worth trying to fix some of these? |
52c88a6
to
eeb5988
Compare
Description
Adds
matrix_dot
to perform an inner product without conjugation in the bra.Details
matrix_dot
functions in vmra.hinner_local
in funcimpl.h todot_local
removing complex conjugation indot_local_X
MADNESS_CHECK
to testvmra.cc so that test fails if error threshold is not met