Merge pull request #2 from lyrasis/csv-converter-nulltonil

Csv converter nulltonil

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    kiba-extend (1.0.0)
+    kiba-extend (1.1.0)
       activesupport
       kiba (>= 3.0.0)
       kiba-common (>= 0.9.0)

lib/kiba/extend.rb

@@ -47,5 +47,17 @@ module Extend
       end
     }
 
+    CSV::Converters[:nulltonil] = lambda{ |s|
+      begin
+        if s == 'NULL'
+          nil
+        else
+          s
+        end
+      rescue ArgumentError
+        s
+      end
+    }
+
   end
 end

lib/kiba/extend/transforms/deduplicate.rb

@@ -42,7 +42,6 @@ def process(row)
             else
               targetvals = targetvals.map{ |vals| vals.first }
             end
-#                binding.pry
             targetvals = targetvals.map{ |val| val.blank? ? nil : val  }
 
             targetvals.each_with_index{ |val, i| row[@targets[i]] = val }

lib/kiba/extend/version.rb

@@ -1,5 +1,5 @@
 module Kiba
   module Extend
-    VERSION = "1.1.0"
+    VERSION = "1.2.0"
   end
 end

spec/kiba/extend_spec.rb

@@ -22,4 +22,26 @@
     end
     after { File.delete(test_csv) if File.exist?(test_csv) }
   end
+
+  describe ':nulltonil csv converter' do
+    test_csv = 'tmp/test.csv'
+    rows = [
+      ['id', 'val'],
+      ['1', 'NULL'],
+      ['2', 'a NULL value'],
+      ['3', ' NULL']
+    ]
+
+    before { generate_csv(test_csv, rows) }
+    it 'converts input data' do
+      expected = [
+        { id: '1', val: nil },
+        { id: '2', val: 'a NULL value' },
+        { id: '3', val: nil }
+      ]
+      result = job_csv(filename: test_csv, incsvopt: {converters: [:stripplus, :nulltonil]})
+      expect(result).to eq(expected)
+    end
+    after { File.delete(test_csv) if File.exist?(test_csv) }
+  end
 end