Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Issue 150 crash with html collation ruby 2.6.x #153

Merged

Conversation

lyndsey-ferguson
Copy link
Owner

Checklist

  • I've run bundle exec rake from the root directory to see all new and existing tests pass
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This fixes a crashing Issue #150 that occurs on Ruby 2.6.x when collating HTML files.

Description

  1. Remove some complexity from how individual test cases are found by name to avoid some issues in REXML for Ruby 2.6.x.
  2. Loosen up the coupling for what nodes are searched for.
  3. Add a Ruby 2.6.x matrix for testing that version.

@lyndsey-ferguson lyndsey-ferguson force-pushed the issue-150-crash-with-html-collation-ruby-2.6.x branch 4 times, most recently from 1bf65aa to 9fbe232 Compare October 11, 2019 23:43
@lyndsey-ferguson lyndsey-ferguson force-pushed the issue-150-crash-with-html-collation-ruby-2.6.x branch from 9376524 to 3858c72 Compare October 11, 2019 23:51
@lyndsey-ferguson lyndsey-ferguson merged commit 3b3aa21 into master Oct 17, 2019
@lyndsey-ferguson lyndsey-ferguson deleted the issue-150-crash-with-html-collation-ruby-2.6.x branch October 17, 2019 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant