Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typos #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fadba06
fix: remove duplicate link definition
lishaduck Jul 10, 2024
3e08a08
fix: missing comma in description
lishaduck Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,7 +714,6 @@ For example, here’s the default value but changed to a single inner array:
[exports]: #exports
[flow]: https://flow.org/
[import/first]: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/first.md
[import/first]: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/first.md
[import/newline-after-import]: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/newline-after-import.md
[import/no-duplicates]: https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md
[import/order-comparison]: #how-is-this-rule-different-from-importorder
Expand Down
2 changes: 1 addition & 1 deletion package-real.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "MIT",
"author": "Simon Lydell",
"repository": "lydell/eslint-plugin-simple-import-sort",
"description": "Easy autofixable import sorting",
"description": "Easy, autofixable import sorting",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked a very trustworthy source called ChatGPT 🙃 for advice on this:

Both can be correct because they convey slightly different nuances:

  1. “Easy, autofixable import sorting”: The comma separates "easy" and "autofixable," suggesting that the import sorting is both easy and autofixable as two distinct qualities.

  2. “Easy autofixable import sorting”: Without the comma, "easy" and "autofixable" work together as a single phrase to describe the import sorting, implying that the process of making imports autofixable is easy.

While the comma adds a slight pause, both forms are grammatically correct and convey a similar overall meaning. The choice depends on whether you want to emphasize the qualities separately or together.

I’m not a native English speaker, so I can’t tell what’s right.

Either way, if we should go with the comma, we should make the same change in the readme.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ChatGPT is right about that.
I would've said it was both easy (as in it makes sense) and autofixable, but it could also be easily autofixable, in which case its fine as is.

"type": "commonjs",
"keywords": [
"eslint",
Expand Down