Set repack-windows drivers default value #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanjj
force-pushed
the
drivers
branch
2 times, most recently
from
00b7c18 to
acefa88
Compare
stgraber
reviewed
Apr 9, 2024
distrobuilder/main_repack-windows.go
Outdated
| } | ||
|
|
||
| defer f.Close() | ||
| c.umounts = append([]string{c.global.sourceDir}, c.umounts...) |
There was a problem hiding this comment.
c.umounts = append(c.umounts, c.global.sourceDir)
stgraber
reviewed
Apr 9, 2024
distrobuilder/main_repack-windows.go
Outdated
| } | ||
|
|
||
| c.umounts = append([]string{driverPath}, c.umounts...) |
There was a problem hiding this comment.
c.umounts = append(c.umounts, driverPath)
There was a problem hiding this comment.
It's following the rule that first mounted should be last umounted
There was a problem hiding this comment.
Ah, I see. Your updated way of handling that seems better (process the list in reverse order during unmount).
And make the usage of drivers, windows-version, windows-arch understandable Signed-off-by: JUN JIE NAN <[email protected]>
stgraber
approved these changes
Apr 9, 2024
tomponline
added a commit
to canonical/lxd-imagebuilder
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make the usage of drivers, windows-version, windows-arch understandable