Tidy up lxc.generator a bit #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
reviewed
Feb 12, 2024
stgraber
reviewed
Feb 12, 2024
|
Looking good @stefanor, can you amend the commits to include the DCO line (Signed-off-by)? |
|
@stefanor looks good. Could you please also rebase this PR? |
Signed-off-by: Stefano Rivera <[email protected]>
Signed-off-by: Stefano Rivera <[email protected]>
Signed-off-by: Stefano Rivera <[email protected]>
Signed-off-by: Stefano Rivera <[email protected]>
Signed-off-by: Stefano Rivera <[email protected]>
Signed-off-by: Stefano Rivera <[email protected]>
stefanor
force-pushed
the
lxc.generator-tweaks
branch
from
c056195 to
c7e3d8f
Compare
|
Rebased and signed-off. |
stgraber
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bundled lxc.generator in https://salsa.debian.org/freexian-team/debusine/-/merge_requests/545 and code-review turned up some suggestions for improvement.