Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtl8192du: Improve 5.19.2/6.0.0 changes a little bit #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rtl8192du: Improve 5.19.2/6.0.0 changes a little bit #96

wants to merge 1 commit into from

Conversation

gotti79
Copy link

@gotti79 gotti79 commented Aug 19, 2022

The 5.19.2/6.0.0 seems a little bit bogus for me so this should be a little improvement.

lwfinger
lwfinger reviewed Aug 19, 2022
View reviewed changes
Copy link
Owner

@lwfinger lwfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your changes are wrong, as are the previous ones. Where wdev->connected was tested. the test should be replaced with one of wdev->connected. Version 5.9.2 is the same as 6.0.0.

I will not be merging this patch and will revert the previous one.

@heitbaum
Copy link
Contributor

I think your changes are wrong, as are the previous ones. Where wdev->connected was tested. the test should be replaced with one of wdev->connected. Version 5.9.2 is the same as 6.0.0.

I will not be merging this patch and will revert the previous one.

@lwfinger my #95 is definitely wrong way around for the if/elif for wdev->connected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwfinger lwfinger lwfinger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gotti79 @heitbaum @lwfinger