Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix program not found on windows #33

Closed
wants to merge 1 commit into from
Closed

Fix program not found on windows #33

wants to merge 1 commit into from

Conversation

TheJeterLP
Copy link

On windows when you try to execute a demo it says *** [execute] Source .pio\build\emulator_64bits\program' not found, needed by target execute'.
So the execute fails. I fixed that with adding the .exe file extension to sdl2_build_extra.py file.

On windows when you try to execute a demo it says *** [execute] Source `.pio\build\emulator_64bits\program' not found, needed by target `execute'.
So the execute fails. I fixed that with adding the .exe file extension to sdl2_build_extra.py file.
@embeddedt
Copy link
Member

I might be wrong but I think this needs (at the very least) a condition to check whether it's compiling on Windows or not, otherwise other platforms will get a similar error, since .exe isn't appended there.

@TheJeterLP
Copy link
Author

I might be wrong but I think this needs (at the very least) a condition to check whether it's compiling on Windows or not, otherwise other platforms will get a similar error, since .exe isn't appended there.

I guess you're right, but i dont know how to do that sadly

@puzrin
Copy link
Collaborator

puzrin commented Mar 11, 2021

That's not acceptable because will break linux/osx. Also, not sure why PROGNAME not includes .exe. It worth to create issue first.

@puzrin puzrin closed this Mar 11, 2021
@puzrin puzrin mentioned this pull request Mar 11, 2021
@puzrin
Copy link
Collaborator

puzrin commented Mar 11, 2021

Created issue (#34).

PS. sorry for rejected PR but thanks for report.

@puzrin
Copy link
Collaborator

puzrin commented Mar 11, 2021

@TheJeterLP is the same problem with "upload"

AlwaysBuild(env.Alias("upload", "$BUILD_DIR/${PROGNAME}", "$BUILD_DIR/${PROGNAME}"))
?

@TheJeterLP
Copy link
Author

@TheJeterLP is the same problem with "upload"

AlwaysBuild(env.Alias("upload", "$BUILD_DIR/${PROGNAME}", "$BUILD_DIR/${PROGNAME}"))

?

yes same problem on upload

@puzrin
Copy link
Collaborator

puzrin commented Mar 12, 2021

@TheJeterLP 7670a6f try this patch and let me know result.

@TheJeterLP
Copy link
Author

@TheJeterLP 7670a6f try this patch and let me know result.

Works fine!

@puzrin
Copy link
Collaborator

puzrin commented Mar 12, 2021

Merged to master. Thanks for your help!

@TheJeterLP
Copy link
Author

no problem :)

@puzrin
Copy link
Collaborator

puzrin commented Mar 15, 2021

@TheJeterLP 0a4536d - does it works on Win? More nice fix.

@TheJeterLP
Copy link
Author

Yes that works too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants