Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs where the r index is wrong #108

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fix bugs where the r index is wrong #108

merged 1 commit into from
Apr 2, 2024

Conversation

sunzigang
Copy link
Contributor

No description provided.

@sunzigang sunzigang mentioned this pull request Mar 29, 2024
Closed
@neuschaefer
Copy link
Contributor

Admittedly, I didn't write the nicest loops there :)

neuschaefer
neuschaefer approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@neuschaefer neuschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

If you have the patience, feel free to refactor the loops to use some kind of for-each loop. That would probably make them a bit more readable.

@neuschaefer neuschaefer mentioned this pull request Apr 2, 2024
Closed
@kisvegabor
Copy link
Member

Thank you!
I merge it now to fix #110.

@kisvegabor kisvegabor merged commit 500e4bb into lvgl:master Apr 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neuschaefer neuschaefer neuschaefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunzigang @neuschaefer @kisvegabor