Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double init semi-bug fix #131

Closed
wants to merge 22 commits into from
Closed

Conversation

jakeatgalileo
Copy link
Contributor

@jakeatgalileo jakeatgalileo commented Nov 3, 2020

Issue: lux-org/lux-widget#20

Fixes the double initialization of the widget.

But now the intent button does not refresh the widget automatically. In the future, we would have to figure out how to manipulate the display of the widget since we are not using self.output anymore.

For now, we can just press the toggle button once to refresh widget - we can have an alert pop up after hitting the intent button, telling the user to refresh. While we do lose a feature, the speed improvements could be worth it. Although using the output widget is probably the correct way to do it.

If we were to merge this, we would need to open a new issue regarding the intent.

@dorisjlee
Copy link
Member

The PR fixes the frontend Host is not attached error that we saw earlier.
image
I ran some performance test with and without this fix. There is a slight difference between the single/double init (with the single init being slightly faster), but this is not significant.

For the real estate dataset, the performance difference is more visible when number of datapoints is larger (np.geomspace(1e4, 4e5, num=9)).

@jakeatgalileo
Copy link
Contributor Author

Ah I see - this makes sense since the backend computations would dominate

@jakeatgalileo jakeatgalileo deleted the feature branch February 16, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants