Modify to_spatial_contracted test and code. Fix #243
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2023 14:38
Ensure that the order of node geometries matches the order of nodes output from igraph::contract, so that attribute-geometry and edge geometry-node geometry associations are preserved by to_spatial_contracted().
|
Hi @MattArran and thank you very much for your PR! Unfortunately, I'm not really familiar with the code behind |
|
Hi Andrea! No problem; it's a small fix and, as #243 mentions, the problem can be avoided in the interrim by sorting the tibble of nodes by the clustering variable before applying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_morphers.m, specifying clusters forto_spatial_contracted()so as to catch the issue with mismatching node geometry (Ref. If the grouping variable is out of order,to_spatial_contractedreturns incorrect node geometries #243)to_spatial_contracted()inmorphers.mto ensure that the order of the updated node geometries matches the order of the updated nodes, even if there are non-duplicated, non-sorted clustering values.Pull request to
mainbranch becausedevelopbranch missing.