Improve yml transform error handling

luuksommers · Mar 8, 2018 · fdd94a4 · fdd94a4
1 parent d6a21f1
commit fdd94a4
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 13 deletions.
diff --git a/src/YmlTransform/Program.cs b/src/YmlTransform/Program.cs
@@ -1,16 +1,29 @@
-using YmlTransform.Models;
+using System;
+using Sitecore.Express;
+using YmlTransform.Exceptions;
+using YmlTransform.Models;
 
 namespace YmlTransform
 {
     class Program
     {
         static void Main(string[] args)
         {
-            var options = new Options();
-            var isValid = CommandLine.Parser.Default.ParseArgumentsStrict(args, options);
-            if (isValid)
+            try
             {
-                YmlTransformer.TransformPath(options.Path, options.TransformFile, options.Recursive);
+                var options = new Options();
+                var isValid = CommandLine.Parser.Default.ParseArgumentsStrict(args, options);
+                if (isValid)
+                {
+                    YmlTransformer.TransformPath(options.Path, options.TransformFile, options.Recursive);
+                }
+            }
+            catch (IncompleteTransformationException e)
+            {
+                Console.ForegroundColor = ConsoleColor.Red;
+                Console.Error.WriteLine("Not all fields were processed. Please verify the following transformations:");
+                Console.Error.WriteLine(e.Message);
+                System.Environment.Exit(1);
             }
         }
     }

diff --git a/src/YmlTransform/YmlTransformer.cs b/src/YmlTransform/YmlTransformer.cs
@@ -16,18 +16,40 @@ public static void TransformFile(string fileToTransform, string transformFile)
         {
             var transformation = GetTransformation(transformFile);
             TransformSingle(transformation, fileToTransform);
+
+            if (!transformation.All(x => x.Used))
+            {
+                throw new IncompleteTransformationException(string.Join(",", transformation.Where(a=>!a.Used).Select(a=>$"{a.Path} {a.FieldId} {a.Type}")));
+            }
         }
 
 
         public static void TransformPath(string path, string transformFile, bool recursive)
         {
+            if (!Path.IsPathRooted(path))
+            {
+                path = Path.Combine(Directory.GetCurrentDirectory(), path);
+            }
+
             var transformations = GetTransformation(transformFile);
             var files = Directory.GetFiles(path, "*.yml",
                 recursive ? SearchOption.AllDirectories : SearchOption.TopDirectoryOnly);
 
             foreach (var file in files)
             {
-                TransformSingle(transformations, file);
+                try
+                {
+                    TransformSingle(transformations, file);
+                }
+                catch (YamlFormatException)
+                {
+
+                }
+            }
+
+            if (!transformations.All(x => x.Used))
+            {
+                throw new IncompleteTransformationException(string.Join(",", transformations.Where(a=>!a.Used).Select(a=>$"{a.Path} {a.FieldId} {a.Type}")));
             }
         }
 
@@ -60,7 +82,7 @@ private static void TransformSingle(List<TransformItem> transformations, string
                                 transformed = true;
                             }
                         }
-                        if (transform.Type == "Unversioned")
+                        else if (transform.Type == "Unversioned")
                         {
                             if (item.UnversionedFields.SelectMany(a => a.Fields).FirstOrDefault(a => a.FieldId == transform.FieldId) is IItemFieldValue field)
                             {
@@ -89,16 +111,11 @@ private static void TransformSingle(List<TransformItem> transformations, string
                         }
                         else
                         {
-                            throw new NotImplementedException();
+                            throw new NotImplementedException(transform.Type);
                         }
                     }
                 }
 
-                if (!transformations.All(x => x.Used))
-                {
-                    throw new IncompleteTransformationException();
-                }
-
                 if (transformed)
                 {
                     Console.WriteLine($"Transformed: {file}");