Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new data structures from the wiki #51

Merged
merged 6 commits into from
Mar 17, 2024

Conversation

robotboy655
Copy link
Contributor

This PR does the following:

  • Implement function overloads from wiki
  • Implement altType for function arguments
  • Implement wiki's function callback definitions
  • Print errors when scraping fails - Maybe it should exit as well?

It partially addresses issues in #47 and reduces reliance on hardcoded overrides.

We do lose some nuance with callback types, such as string[] being replaced with table in concommand.Add autocomplete callback, but I think we can live with that.

@luttje
Copy link
Owner

luttje commented Mar 16, 2024

Heya @robotboy655 , thanks again for your work.

I see a test is failing. If it's only two or so tests, I'm fine with you commenting them for now, instead of writing new ones. I will work on writing some better tests for your code another time.

Let me know if you think this is good to merge and I'll get on it

@luttje luttje added the enhancement New feature or request label Mar 16, 2024
@robotboy655
Copy link
Contributor Author

@luttje I have fixed the tests.

I have tested the resulting output from my PR against a the previous version, and here's the result:
image

Basically only the documentation that was overwritten in custom/ has changed, so yeah, I think this is safe to merge.

@luttje luttje merged commit 0e6c5d4 into luttje:main Mar 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants