-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add function argument parameters #40
Feature/add function argument parameters #40
Conversation
The callback receives `...` arguments, which is too complex for LuaLS to handle.
Unless you can have a fraction of a bit, it makes sense to put an integer here.
Alright, I have decided that it wouldn't make sense to do anything for I think this is all the functions with function arguments. Let me know if I missed any. |
Since I'm busy with other projects, if I have to properly review and test your PR we'd risk this not getting picked up by me. On the surface your PR looks good though. For that reason I've decided I'll just merge it without much more testing, so we can get your great contributions into the project faster. Thank you so much for your contribution! |
Things seem to be looking alright. The workflow successfully scraped and your custom overrides have been applied: 3b2193a Thanks again! |
Closes #37.
I've tried my best to conform to the argument type descriptions, although, I couldn't fully implement all of them:
search.AddProvider
- return type must be a special table with the fields:string text
- Text to "Copy to clipboard"function func
- Function to use/spawn the itemPanel icon
- A panel to add to spawnmenutable words
- A table of words? (Even the wiki isn't sure about this one.)I've also looked through the source code of some library functions to see how some callbacks are used to guess the return type.
Some classes/structures (like
HTTPRequest
) may contain callbacks, but I have only changed the functions.Due to the above, this may still be an issue in progress.