Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add function argument parameters #40

Merged
merged 14 commits into from
Jan 21, 2024
Merged

Feature/add function argument parameters #40

merged 14 commits into from
Jan 21, 2024

Conversation

b0mbie
Copy link
Contributor

@b0mbie b0mbie commented Jan 17, 2024

Closes #37.

I've tried my best to conform to the argument type descriptions, although, I couldn't fully implement all of them:

  • search.AddProvider - return type must be a special table with the fields:
    • string text - Text to "Copy to clipboard"
    • function func - Function to use/spawn the item
    • Panel icon - A panel to add to spawnmenu
    • table words - A table of words? (Even the wiki isn't sure about this one.)
  • I may have missed some other functions with callbacks.

I've also looked through the source code of some library functions to see how some callbacks are used to guess the return type.

Some classes/structures (like HTTPRequest) may contain callbacks, but I have only changed the functions.

Due to the above, this may still be an issue in progress.

P.S. At this point, I just want the maintainers of GLua to use a syntax compatible with LuaLS.

@b0mbie b0mbie marked this pull request as draft January 17, 2024 14:54
@luttje luttje added the enhancement New feature or request label Jan 17, 2024
Unless you can have a fraction of a bit, it makes sense to put an integer here.
@b0mbie
Copy link
Contributor Author

b0mbie commented Jan 19, 2024

Alright, I have decided that it wouldn't make sense to do anything for search.AddProvider.
Other functions' table arguments and returns don't get special treatment, so they also shouldn't here.

I think this is all the functions with function arguments. Let me know if I missed any.

@b0mbie b0mbie marked this pull request as ready for review January 19, 2024 12:03
@luttje
Copy link
Owner

luttje commented Jan 21, 2024

Since I'm busy with other projects, if I have to properly review and test your PR we'd risk this not getting picked up by me. On the surface your PR looks good though. For that reason I've decided I'll just merge it without much more testing, so we can get your great contributions into the project faster.

Thank you so much for your contribution!

@luttje luttje merged commit 4356d7c into luttje:main Jan 21, 2024
2 checks passed
@luttje
Copy link
Owner

luttje commented Jan 21, 2024

Things seem to be looking alright. The workflow successfully scraped and your custom overrides have been applied: 3b2193a

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function argument parameters
2 participants