Optimize scraping #8 #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luttje
added
enhancement
|
wiki.facepunch.com/gmod/~pagelist?format=json's |
|
@aske02 Wow, I can't believe I missed that. I even looked at this data and somehow concluded "this is not useful". You're right, we could put the update count into the I probably won't implement this until I have some more time available, I've got a ton of other projects that I want to focus my attention on now. Nevertheless, thanks so much for helping out with this, and so quickly as well! Much appreciated! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8 I stated that it would be perfectly achievable to only scrape the changed pages, instead of the entire wiki. This PR attempted to implement that, however I ran into an issue:
I seem to have been mistaken, thinking there would be a list on the gmod wiki with all changes. Using that we could scrape only updates. However the only list I can find is https://wiki.facepunch.com/gmod/~recentchanges which shows only recent changes (last 30 days?) and it doesn't allow pagination to discover more changes.
If anyone has got any ideas around this I'm open to suggestions.
I'll leave this PR as a draft until a solution is found. I won't actively look into a solution myself, so help is greatly appreciated. In any case this is marked low-priority, since the scraping of the entire wiki works fine (besides being a bit wasteful).