Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for LXC clone #99

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Add support for LXC clone #99

merged 2 commits into from
Oct 26, 2023

Conversation

alperencelik
Copy link
Contributor

Hi,

I'm currently working on a Kubernetes operator for Proxmox and am impressed by the "go-proxmox" project. I realized that cloning an LXC is not implemented by the client so my PR tries to have an implementation of LXC cloning.

Here is the relevant API documentation on Proxmox:

containers.go Outdated Show resolved Hide resolved
containers.go Outdated Show resolved Hide resolved
@alperencelik
Copy link
Contributor Author

Thanks for the prompt response. I tried to cover things that you mentioned so it might require another review.

@luthermonson
Copy link
Owner

good work!

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #99 (4affbb8) into main (b660812) will increase coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   26.10%   26.16%   +0.05%     
==========================================
  Files          15       15              
  Lines        1712     1739      +27     
==========================================
+ Hits          447      455       +8     
- Misses       1245     1264      +19     
  Partials       20       20              
Files Coverage Δ
types.go 57.71% <ø> (ø)
containers.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@luthermonson luthermonson merged commit f451415 into luthermonson:main Oct 26, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants