Fix VirtualMachine.IsPaused #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition in the IsPaused function checks whether the VM is running, not whether it's in a pause state.
rybnico
added a commit
to rybnico/cluster-api-provider-proxmox
that referenced
this pull request
Oct 5, 2024
This reverts commit c5d15e5. Because of this bug luthermonson/go-proxmox#169
luthermonson
approved these changes
Oct 6, 2024
mcbenjemaa
added a commit
to ionos-cloud/cluster-api-provider-proxmox
that referenced
this pull request
Dec 5, 2024
* Return VMIDFreeErr or the error object itself if CheckID returns true/an error * Rename VMIDFreeErr to ErrVMIDFree and fix comment to make linter happy * feat: Add ability to specify range of VM IDs to use * Fix codespell error: fix spelling * When checking if a vmid is free, first check the existing ProxmoxMachines before querying the Proxmox API. * Check that the vmid of the Proxmox machine is set (not -1) before adding it to usedVMIDs * Move spec.vmidRange from ProxmoxCluster to ProxmoxMachine * Update github.com/luthermonson/go-proxmox to v0.2.0 * Revert "Update github.com/luthermonson/go-proxmox to v0.2.0" This reverts commit c5d15e5. Because of this bug luthermonson/go-proxmox#169 * Update github.com/luthermonson/go-proxmox to v0.2.1 * Add test for ClusterScope.ListProxmoxMachinesForCluster * Fix wording in ProxmoxMachine types test * Rename vmidRange to vmIDRange to follow k8s API conventions * Add validation for vmIDRange: end should be greater than or equal to start * Set failureMessage and failureReason when ErrNoVMIDInRangeFree is thrown * Refactor getVMID to improve code quality --------- Co-authored-by: Mohamed Chiheb Ben Jemaa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a small bug in the VirtualMachine.IsPaused function:
The condition in the IsPaused function checks whether the VM is running, not whether it's in a pause state.