Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function that Unmount Cloud ISO if not needed #131

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

mcbenjemaa
Copy link
Contributor

@mcbenjemaa mcbenjemaa commented Mar 13, 2024

This PR:

  • Adds a function UnmountCloudInitISO to unattach and delete the cloudinit iso.

Closes #127

@mcbenjemaa
Copy link
Contributor Author

@luthermonson can you have a look,
and can we release this?

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 26.90%. Comparing base (fdb95a1) to head (55a167c).
Report is 15 commits behind head on main.

❗ Current head 55a167c differs from pull request most recent head 1ce446d. Consider uploading reports for the commit 1ce446d to get more accurate results

Files Patch % Lines
virtual_machine.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   25.95%   26.90%   +0.95%     
==========================================
  Files          15       15              
  Lines        1753     1966     +213     
==========================================
+ Hits          455      529      +74     
- Misses       1278     1403     +125     
- Partials       20       34      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

virtual_machine.go Outdated Show resolved Hide resolved
virtual_machine.go Outdated Show resolved Hide resolved
virtual_machine.go Outdated Show resolved Hide resolved
@luthermonson
Copy link
Owner

looks great, one last quick change if you don't mind

@luthermonson luthermonson merged commit 0a31b09 into luthermonson:main Mar 22, 2024
1 check passed
@luthermonson
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unmount Cloudinit ISO
2 participants