Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨feat: Enhance support for /access #125

Merged
merged 5 commits into from
Mar 5, 2024
Merged

✨feat: Enhance support for /access #125

merged 5 commits into from
Mar 5, 2024

Conversation

alperencelik
Copy link
Contributor

This PR aims to complete /access API calls for Proxmox. Here is the documentation of /access API.

https://pve.proxmox.com/pve-docs/api-viewer/index.html#/access

virtual_machine.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 26.37%. Comparing base (fdb95a1) to head (8928924).
Report is 7 commits behind head on main.

Files Patch % Lines
access.go 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   25.95%   26.37%   +0.42%     
==========================================
  Files          15       15              
  Lines        1753     1797      +44     
==========================================
+ Hits          455      474      +19     
- Misses       1278     1303      +25     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luthermonson
Copy link
Owner

tests! you absolute mad lad

@luthermonson luthermonson merged commit a6a1921 into luthermonson:main Mar 5, 2024
3 checks passed
@alperencelik
Copy link
Contributor Author

I know I was a little lazy to add them before but I had to start somewhere 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants