Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete function for containers(LXC) #103

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Add delete function for containers(LXC) #103

merged 1 commit into from
Nov 11, 2023

Conversation

alperencelik
Copy link
Contributor

This commit adds functionality for deleting the Container object(s).

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #103 (efa5776) into main (bcc4e8f) will decrease coverage by 0.09%.
Report is 6 commits behind head on main.
The diff coverage is 20.58%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   26.16%   26.07%   -0.09%     
==========================================
  Files          15       15              
  Lines        1739     1745       +6     
==========================================
  Hits          455      455              
- Misses       1264     1270       +6     
  Partials       20       20              
Files Coverage Δ
types.go 57.71% <ø> (ø)
cluster.go 86.20% <87.50%> (ø)
containers.go 0.00% <0.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed but for further reference there might be new functions around it, so it's a choice to keep or delete.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can always add to types! Thanks for this

@luthermonson luthermonson merged commit b852c05 into luthermonson:main Nov 11, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants