Update the RecursiveSNARK API (Nova forward port) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove unused digest computations * avoid a verifier having to recompute a digest * update crate version Restore digest computation and fix API inconsistency (#242) * Revert "Digest simplifications (#238)" This reverts commit 71ecb66. * upgrade neptune * make the public interface uniform wrt refs vs. copies * simplify prove_step
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 30, 2023
- Updated the `nova` dependency branch in Cargo.toml for compatibility testing - adapts tohttps://github.com/lurk-lang/arecibo/pull/87
- Updated `RecursiveSNARK` struct in `supernova/mod.rs` to include `z0_primary` and `z0_secondary` fields, simplifying method parameters. - Refactored `prove_step` method in `RecursiveSNARK` struct to leverage the new instance variables, `z0_primary` and `z0_secondary`, - Replaced all usages of `z0_primary` and `z0_secondary` in function calls with their respective instance variables.
huitseeker
force-pushed
the
forward_port_238_242
branch
from
9f93572 to
95796df
Compare
|
Companion PR at lurk-lab/lurk-beta#811. |
huitseeker
added a commit
to huitseeker/lurk-rs
that referenced
this pull request
Oct 30, 2023
- Updated the `nova` dependency branch in Cargo.toml for compatibility testing - adapts tohttps://github.com/lurk-lang/arecibo/pull/87
mpenciak
approved these changes
Oct 30, 2023
github-merge-queue bot
pushed a commit
to lurk-lab/lurk-beta
that referenced
this pull request
Oct 30, 2023
* Adapt to upstream Nova RecursiveSNARK API changes - Updated the `nova` dependency branch in Cargo.toml for compatibility testing - adapts tohttps://github.com/lurk-lang/arecibo/pull/87 * refactor: Adapt to upstream Supernova changes - Removed the unnecessary passing of `&z0_primary` and `&z0_secondary` as arguments in the `prove_step` method. * fix: target the dev branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports microsoft/Nova#238 and microsoft/Nova#242 (squashed together, as part of #242 reverts part of #238).
TL;DR,
z0no longer needs to be provided to Nova on everyprove_step, and the creation of theRecursiveSNARKcopies a set ofz0_{primary, secondary}passed by reference. This is expected to require adjustment in Lurk.I added one commit for the SuperNova adjustments.