chore: Remove 'fcomm' package and associated files #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the entire `fcomm` module, 👋 - Deleted numerous `fcomm` related source and snapshot files from the project. - Removed `test_make_fcomm_examples` from excludedLinux Tests phase in GitHub Actions workflow - Updated README link to fcomm -> demo under 'Proofs' section. - Removed `fcomm` as workspace member in `Cargo.toml` and from GitHub Actions CI/CD setup.
This was referenced Nov 8, 2023
samuelburnham
approved these changes
Nov 8, 2023
This was referenced Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fcommmodule, 👋fcommrelated source and snapshot files from the project.test_make_fcomm_examplesfrom excludedLinux Tests phase in GitHub Actions workflowfcommas workspace member inCargo.tomland from GitHub Actions CI/CD setup.Closes #118 #346 #785 by making them obsolete.