Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NIVC support for the REPL #1119

Merged
merged 1 commit into from
Feb 14, 2024
Merged

feat: NIVC support for the REPL #1119

merged 1 commit into from
Feb 14, 2024

Conversation

arthurpaulino
Copy link
Contributor

  • Extend LurkProof and ProtocolProof to encode SuperNova proofs as well
  • Add a new Backend::SuperNova variant
  • Code the plumbing for SuperNova proof generation
  • Extend the protocol API to handle a backend argument so it can use SuperNova as well

Closes #533

@arthurpaulino arthurpaulino requested review from a team as code owners February 12, 2024 20:34
@arthurpaulino arthurpaulino mentioned this pull request Feb 12, 2024
Closed
@arthurpaulino arthurpaulino force-pushed the ap/nivc-repl-support branch 4 times, most recently from 02464b4 to 0ca9c58 Compare February 13, 2024 13:48
@arthurpaulino
feat: NIVC support for the REPL
2451f45 
* Extend LurkProof and ProtocolProof to encode SuperNova proofs as well
* Add a new Backend::SuperNova variant
* Code the plumbing for SuperNova proof generation
* Extend the protocol API to handle a backend argument so it can use
  SuperNova as well
huitseeker
huitseeker reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of small improvements, I like it. Would it make sense to fast-forward and make Supernova the default?

@arthurpaulino
Copy link
Contributor Author

Lots of small improvements, I like it. Would it make sense to fast-forward and make Supernova the default?

Will do on a follow-up PR 👍🏼

@arthurpaulino arthurpaulino added this pull request to the merge queue Feb 14, 2024
Merged via the queue into main with commit fc1e8dc Feb 14, 2024
11 checks passed
@arthurpaulino arthurpaulino deleted the ap/nivc-repl-support branch February 14, 2024 14:43
This was referenced Feb 14, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize the REPL
2 participants
@arthurpaulino @huitseeker