Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed load command #1040

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Fixed load command #1040

merged 1 commit into from
Jan 11, 2024

Conversation

gabriel-barrett
Copy link
Contributor

The load command used to use the path of the REPL, always. Now it uses the path of the file's directory if the load command was read from the file

@gabriel-barrett gabriel-barrett requested a review from a team as a code owner January 11, 2024 19:50
Copy link
Contributor

@samuelburnham samuelburnham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@@ -41,7 +41,7 @@ pub(super) struct MetaCmd<F: LurkField, C: Coprocessor<F> + Serialize + Deserial
format: &'static str,
description: &'static [&'static str],
example: &'static [&'static str],
pub(super) run: fn(repl: &mut Repl<F, C>, args: &Ptr) -> Result<()>,
pub(super) run: fn(repl: &mut Repl<F, C>, args: &Ptr, file_path: &Utf8Path) -> Result<()>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make this an Option but not important I think

@gabriel-barrett gabriel-barrett added this pull request to the merge queue Jan 11, 2024
github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
github-actions bot pushed a commit that referenced this pull request Jan 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 11, 2024
@samuelburnham samuelburnham added this pull request to the merge queue Jan 11, 2024
Merged via the queue into main with commit dba2a91 Jan 11, 2024
12 checks passed
@samuelburnham samuelburnham deleted the fix-load-file branch January 11, 2024 22:57
github-actions bot pushed a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants