Merge pull request #4 from pprkut/generic-builder-type

MySQL/MariaDB: Revert back to generic return type for get_new_dml_que…
lunr-php · Nov 7, 2024 · 18815d6 · 18815d6
2 parents 10869c6 + cbf77da
commit 18815d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Lunr/Gravity/MariaDB/MariaDBConnection.php b/src/Lunr/Gravity/MariaDB/MariaDBConnection.php
@@ -46,9 +46,9 @@ public function __destruct()
      *
      * @param bool $simple Whether to return a simple query builder or an advanced one.
      *
-     * @return ($simple is true ? MariaDBSimpleDMLQueryBuilder : MariaDBDMLQueryBuilder) New DatabaseDMLQueryBuilder object instance
+     * @return object New DatabaseDMLQueryBuilder object instance
      */
-    public function get_new_dml_query_builder_object(bool $simple = TRUE): MariaDBDMLQueryBuilder|MariaDBSimpleDMLQueryBuilder
+    public function get_new_dml_query_builder_object(bool $simple = TRUE): object
     {
         $querybuilder = new MariaDBDMLQueryBuilder();
         if ($simple === TRUE)

diff --git a/src/Lunr/Gravity/MySQL/MySQLConnection.php b/src/Lunr/Gravity/MySQL/MySQLConnection.php
@@ -342,9 +342,9 @@ public function set_option(int $key, mixed $value): bool
      *
      * @param bool $simple Whether to return a simple query builder or an advanced one.
      *
-     * @return ($simple is true ? MySQLSimpleDMLQueryBuilder : MySQLDMLQueryBuilder) New DatabaseDMLQueryBuilder object instance
+     * @return object New DatabaseDMLQueryBuilder object instance
      */
-    public function get_new_dml_query_builder_object(bool $simple = TRUE): MySQLSimpleDMLQueryBuilder|MySQLDMLQueryBuilder
+    public function get_new_dml_query_builder_object(bool $simple = TRUE): object
     {
         $querybuilder = new MySQLDMLQueryBuilder();
         if ($simple === TRUE)