Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types and test functions #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SMillerDev
Copy link
Contributor

No description provided.

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marcella-galambos-move
Copy link

unit test CI fails

Copy link

@marcella-galambos-move marcella-galambos-move left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to me a somewhat duplicated version of #3, no?

* @dataProvider nonArrayValueProvider
* @covers Lunr\Core\Configuration::convert_array_to_class
*/
public function testConvertArrayToClassWithNonArrayValues(mixed$input): void

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants