-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFI support for lune #243
Draft
qwreey
wants to merge
84
commits into
lune-org:main
Choose a base branch
from
qwreey:ffi
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
FFI support for lune #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwreey
force-pushed
the
ffi
branch
2 times, most recently
from
August 25, 2024 14:00
42930da
to
d63c3dd
Compare
@qwreey Small thing - is it possible to link this to the relevant issue? |
struct.size: Returns a non-zero actual size rewrite use super:: => use crate::
* Fixes incorrect function signatures for callables. * Now correctly returns the main module.
type plus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is still a lot of work to be done, Most of the specs are well polished.
I have discussed it with many people (mostly, Korean) to ensure that it is done cleanly while supporting as many cases as possible, but it has not been released to the lune community yet.
At first time, It was a personal fork that I did not intend to merge into lune, but the specs and implementation have improved a lot, so I think the quality will be sufficient, so I am discussing it publicly and developing it publicly.
Since the specifications-related parts are still in Korean, we would like to translate them into English as soon as possible.
There are many comments written in the code that will be helpful. (Comments are written in English.)
The direction this library pursues is to allow Lua to select which data areas Lua can handle and which areas will be automatically managed.
Lua can create a space on the heap that it can manage as needed, provide that space to the outside as a pointer, or use it to hold data that Lua cannot handle. (such as unsigned 64 bit int, c struct)
Except for pointer operations, all operations are safe. I'm looking for a safer way to handle pointer arithmetic. If you have any comments about this, please write them here.
I will update progress as soon as specifications translating is done in this thread.