Fix: The "total" column of the shipping order-lines in the database doesn't include taxes #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oesn't include taxes. This is because the shippingTotal is retrieved from the Cart's shippingAddress, and the taxes aren't added to that shippingTotal by the CalculateTax pipeline. Also: The TestTaxDriver doesn't take into account whether prices are stored inclusive of tax or not, which results in it calculating the wrong taxBreakdown if they are.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prices are stored exclusive of tax, the subtotal should exclude taxes, and the total should include taxes.
The issue occurs because the CalculateTax pipeline adds the tax to the cart's shippingTotal, but not to the shippingAddress' shippingTotal. The address' shippingTotal is then used by the CreateShippingLine pipeline to create the record in the lunar_order_lines table.
Screenshot of the lunar_order_lines table, filtered to only show the shipping lines:
Also: The TestTaxDriver doesn't take into account whether prices are stored inclusive of tax or not, which results in it calculating the wrong taxBreakdown if they are.