cleanup ProductOption accessor/mutator and fix fields casting #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alecritson
previously approved these changes
May 28, 2024
|
@alecritson @wychoong is this still needed? I can see it's draft, but at the same time Alec approved it. |
|
Not sure why it’s changed to draft |
wychoong
changed the title
|
@glennjacobs I took a fresh look on it, this should be the proper way. updated my findings in the first comment. It also makes me think should all the usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the accessor/mutator defined for the
nameandlabelfields, the cast is never usedthis PR removed the redundant accessor/mutator and changed to
AsArrayObjectcast instead ofAs Collectionusing
AsArrayObjectallows following usageas compared to previous accessor/mutator json_encode
or
AsCollection