Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french language #1630

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Add french language #1630

merged 8 commits into from
Nov 20, 2024

Conversation

StephaneBour
Copy link
Contributor

Hello,

As for version 0.7 (#1489), here are the French translation files for the admin part.

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 8:55am

@StephaneBour StephaneBour changed the title Add french language for admin [1.x] Add french language for admin Mar 13, 2024
@glennjacobs glennjacobs added this to the v1.0 milestone Mar 13, 2024
@glennjacobs
Copy link
Contributor

Thanks. But as we're still in alpha and so much can potentially change, I'm not going to merge this until we're closer to a stable release.

@glennjacobs glennjacobs changed the title [1.x] Add french language for admin Add french language for admin Mar 13, 2024
@StephaneBour
Copy link
Contributor Author

No worries, I will adapt just before the release.

@glennjacobs
Copy link
Contributor

No worries, I will adapt just before the release.

I'll change to draft for the moment and once we hit beta we can come back to it.

@glennjacobs glennjacobs marked this pull request as draft May 22, 2024 07:44
@glennjacobs glennjacobs self-assigned this May 22, 2024
@glennjacobs glennjacobs added the i18n Language file contributions label Jul 5, 2024
@StephaneBour
Copy link
Contributor Author

@glennjacobs I updated from 1.0-beta1

@StephaneBour StephaneBour marked this pull request as ready for review August 28, 2024 20:14
@StephaneBour StephaneBour changed the title Add french language for admin Add french language Aug 28, 2024
@glennjacobs
Copy link
Contributor

@StephaneBour many thanks for this. I can see there's some updates for other languages. Can we ensure this PR is only for French? Also, could you give it a final check considering some bits may have changed and then we'll get it merged in.

@StephaneBour
Copy link
Contributor Author

@glennjacobs this commit is a missing translation in English : 56ebfc9

I check now if all translation are ok in French.

@StephaneBour
Copy link
Contributor Author

It's ok, all keys in en are in fr 👍🏻

@glennjacobs glennjacobs merged commit 736d14c into lunarphp:1.x Nov 20, 2024
21 checks passed
@glennjacobs
Copy link
Contributor

Many thanks @StephaneBour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Language file contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants