Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Limit the list of sku with line break #1508

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

lguichard
Copy link
Contributor

Capture d’écran 2024-01-28 à 18 30 30

Copy link

vercel bot commented Jan 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2024 2:51pm

@alecritson
Copy link
Collaborator

Maybe to save height space we can limit to just one SKU and show the "plus x more" since I don't think it's too much of a difference. What do you think?

@lguichard
Copy link
Contributor Author

@alecritson I tested this option but I had a conflict with the click on the resource.

Enregistrement.de.l.ecran.2024-01-30.a.10.29.14.mov

@glennjacobs glennjacobs added the enhancement Improvement to existing functionality label Jan 31, 2024
@glennjacobs glennjacobs added this to the v1.0 milestone Jan 31, 2024
@glennjacobs glennjacobs merged commit 8785159 into lunarphp:1.x Jan 31, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants