Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - Translated column #1501

Merged
merged 12 commits into from
Mar 11, 2024
Merged

Feature - Translated column #1501

merged 12 commits into from
Mar 11, 2024

Conversation

lguichard
Copy link
Contributor

This PR add new custom TranslatedTextColumn use for translated fields with some options :

  • limitedToolip : display tooltip if the column contents exceeds the length limit.
  • attributeData : Render from attribute_data field

@vercel Vercel
Copy link

vercel bot commented Jan 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 11:17pm

glennjacobs
glennjacobs requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@glennjacobs glennjacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we import the class, rather than using the full namespace of \Lunar\Admin\Support\Tables\Columns\TranslatedTextColumn please?

@glennjacobs glennjacobs added the enhancement Improvement to existing functionality label Jan 31, 2024
@glennjacobs glennjacobs added this to the v1.0 milestone Jan 31, 2024
@lguichard
Copy link
Contributor Author

@glennjacobs Ok !

@lguichard
Copy link
Contributor Author

@glennjacobs That's it

@glennjacobs glennjacobs merged commit 1f38915 into lunarphp:1.x Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennjacobs glennjacobs glennjacobs requested changes

Assignees
No one assigned
Labels
enhancement Improvement to existing functionality
Projects
Roadmap
Status: Done
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lguichard @glennjacobs