Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to enable tax on shipping boolean inside the TaxZone model #1353

Closed
wants to merge 5 commits into from

Conversation

cambad
Copy link
Contributor

@cambad cambad commented Dec 5, 2023

Context

Please describe your Pull Request as best as possible, explaining what it provides and why it is of value, referencing any related Issues.

I implemented an e-commerce website for a client that has mainly customers in the USA. They wanted to have the option to have tax on the shipping amount or not. So I decided to first extend the SystemTaxDriver of Lunar and add the code inside of it (and all the features).

Now, that the site is in production and the feature is working well, I wanted to share this option as I think it could be interesting for other people.

I tested the implementation with the Lunar's demo and inside my project too, to be sure everything is working well.

If you need more information, don't hesitate to ask! Please note that as it's a new feature I targeted the main branch.

Documentation updates

I added the tax_on_shipping field inside the TaxZone part of the documentation.

Automated tests

I wrote new tests relative to the feature inside the SystemTaxDriverTest class.

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 9:35pm

@glennjacobs glennjacobs added the enhancement Improvement to existing functionality label Dec 18, 2023
@glennjacobs glennjacobs added this to the v0.8 milestone Dec 18, 2023
@glennjacobs glennjacobs requested a review from alecritson May 6, 2024 20:55
@glennjacobs
Copy link
Contributor

Closing, as I don't believe this is required, as we have tax classes applied to shipping options that allow you to set a zero rate.

@glennjacobs glennjacobs closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants