Skip to content

Commit

Permalink
Fix order line observer (#1732)
Browse files Browse the repository at this point in the history
  • Loading branch information
repl6669 authored and alecritson committed Aug 19, 2024
1 parent 8205935 commit 395ee98
Show file tree
Hide file tree
Showing 2 changed files with 141 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/core/src/Observers/OrderLineObserver.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class OrderLineObserver
*/
public function creating(OrderLine $orderLine)
{
if ($orderLine->type != 'shipping' && ! $orderLine->purchasable instanceof Purchasable) {
if (! in_array(Purchasable::class, class_implements($orderLine->purchasable_type, true))) {
throw new NonPurchasableItemException($orderLine->purchasable_type);
}
}
Expand All @@ -27,7 +27,7 @@ public function creating(OrderLine $orderLine)
*/
public function updating(OrderLine $orderLine)
{
if ($orderLine->type != 'shipping' && ! $orderLine->purchasable instanceof Purchasable) {
if (! in_array(Purchasable::class, class_implements($orderLine->purchasable_type, true))) {
throw new NonPurchasableItemException($orderLine->purchasable_type);
}
}
Expand Down
139 changes: 139 additions & 0 deletions packages/core/tests/Stubs/DataTypes/TestPurchasable.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,139 @@
<?php

namespace Lunar\Tests\Stubs\DataTypes;

use Illuminate\Support\Collection;
use Lunar\Base\Purchasable;
use Lunar\DataTypes\Price;
use Lunar\Models\TaxClass;

class TestPurchasable implements Purchasable
{
public function __construct(
public $name,
public $description,
public $identifier,
public Price $price,
public TaxClass $taxClass,
public $taxReference = null,
public $option = null,
public bool $collect = false,
public $meta = null
) {
// ..
}

/**
* Get the price for the purchasable item.
*
* @return \Lunar\DataTypes\Price
*/
public function getPrice()
{
return $this->price;
}

/**
* Get prices for the purchasable item.
*/
public function getPrices(): Collection
{
return collect([
$this->price,
]);
}

/**
* Return the purchasable unit quantity.
*/
public function getUnitQuantity(): int
{
return 1;
}

/**
* Return the purchasable tax class.
*/
public function getTaxClass(): TaxClass
{
return $this->taxClass;
}

/**
* Return the purchasable tax reference.
*
* @return string|null
*/
public function getTaxReference()
{
return $this->taxReference;
}

/**
* Return what type of purchasable this is, i.e. physical,digital,shipping.
*
* @return string
*/
public function getType()
{
return 'test-purchsable';
}

/**
* Return the name for the purchasable.
*
* @return string
*/
public function getName()
{
return $this->name;
}

/**
* Return the description for the purchasable.
*
* @return string
*/
public function getDescription()
{
return $this->description;
}

/**
* Return the option for this purchasable.
*
* @return string|null
*/
public function getOption()
{
return $this->option;
}

/**
* Return a unique string which identifies the purchasable item.
*
* @return string
*/
public function getIdentifier()
{
return $this->identifier;
}

/**
* Returns whether the purchasable item is shippable.
*
* @return bool
*/
public function isShippable()
{
return false;
}

/**
* {@inheritDoc}
*/
public function getThumbnail()
{
return null;
}
}

0 comments on commit 395ee98

Please sign in to comment.