Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(threat) tolerate empty namespace URI in namespace declaration #38

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix(threat) tolerate empty namespace URI in namespace declaration #38

merged 1 commit into from
Jun 27, 2024

Conversation

hanshuebner
Copy link
Contributor

No description provided.

alerque
alerque previously requested changes Jun 27, 2024
View reviewed changes
LICENSE Outdated Show resolved Hide resolved
rockspecs/luaexpat-1.5.2-1.rockspec Outdated Show resolved Hide resolved
src/lxplib.h Outdated Show resolved Hide resolved
@hanshuebner
Copy link
Contributor Author

@alerque Makes total sense, sorry for not thinking about it myself.

@hanshuebner
Copy link
Contributor Author

@alerque @Tieske I'd appreciate a review & merge. I've got the release stuff on a separate branch that I'll open a PR for once this one is merged.

@hanshuebner hanshuebner requested a review from alerque June 27, 2024 12:13
@Tieske
Copy link
Member

Tieske commented Jun 27, 2024

I added #39 with an additional test

@Tieske Tieske dismissed alerque’s stale review June 27, 2024 14:16

explanation accepted

@Tieske Tieske merged commit 8ee20c5 into lunarmodules:master Jun 27, 2024
14 checks passed
@Tieske Tieske mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanshuebner @Tieske @alerque