Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
nadav3396 committed Feb 19, 2024
1 parent 67fcb80 commit 4e0f942
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/version-testing.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
name: Version Testing
on:
push:
schedule:
- cron: "0 7 * * *"
jobs:
test-untested-versions:
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -79,7 +81,7 @@ jobs:
- run: PYTHONPATH=${PYTHONPATH}:$(pwd)/scripts python3 -m gather_version_artifacts
- run: git --no-pager diff
- run: rm -rf versions_artifacts # the artifacts shouldn't be committed
- run: echo "::set-output name=branch_name::$(date +version-testing-%Y%m%d)_ng"
- run: echo "::set-output name=branch_name::$(date +version-testing-%Y%m%d)"
id: branch_name
- run: | # update 'Supported packages' section in README.md
PYTHONPATH=${PYTHONPATH}:$(pwd)/scripts python3 -m update_supported_packages_documentation
Expand All @@ -96,7 +98,7 @@ jobs:
branch: ${{steps.branch_name.outputs.branch_name}}
commit-message: ${{ env.new_versions }}
body: ${{ env.new_versions }}
base: fix-tested-versions
base: main
labels: version-testing, automerge
reviewers: GuyMoses,nadav3396,shanishiri

Expand Down
3 changes: 0 additions & 3 deletions scripts/test_untested_versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,13 @@ for (const package of instrumentationToTest) {
`\nTesting ${untestedVersions.length} untested versions of ${package} since ${highestExistingVersion}...`
);
backupPackageVersions(package);
console.info(untestedVersions)

// if this is run locally, only test the first and last versions
untestedVersions =
isRunningOnCI || untestedVersions.length < 3
? untestedVersions
: [untestedVersions[0], untestedVersions[untestedVersions.length - 1]];

console.info(untestedVersions)

fs.writeFileSync(
`src/instrumentations/${package}/tested_versions/${runtimeVersion}/${package}`,
untestedVersions.join('\n') + '\n'
Expand Down

0 comments on commit 4e0f942

Please sign in to comment.