fix: split http instrumentation to core logic and http lib integration #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagivoululumigo
force-pushed
the
RD-12714-generalize-current-http-instrumentation
branch
from
dc6e7c7 to
0b36ed7
Compare
harelmo-lumigo
approved these changes
May 9, 2024
GuyMoses
approved these changes
May 12, 2024
sagivoululumigo
commented
May 15, 2024
sagivoululumigo
commented
May 15, 2024
sagivoululumigo
commented
May 15, 2024
sagivoululumigo
commented
May 15, 2024
lumigo-circleci-github-user
pushed a commit
that referenced
this pull request
Jun 3, 2024
## [1.93.1](v1.93.0...v1.93.1) (2024-06-03) ### Bug Fixes * split http instrumentation to core logic and http lib integration ([#482](#482)) ([947fbd0](947fbd0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first stage of adding native node fetch instrumentation.
This PR splits the existing http library instrumentation to the core logic of tracing a generic http request (the
BaseHttpclass) and the instrumentation connecting that logic to thehttp/httpslibraries (theHttpclass).The next stage will be in a separate PR that will use the
BaseHttpclass to integrate to a new http library calledundici(This is the library that native node fetch uses behind the scenes)